[191] Support: to Python 3.12#226
Conversation
abdullahQureshee
force-pushed
the
maq/191
branch
2 times, most recently
from
7ec1299 to
0a51874
Compare
|
@irtazaakram I can't find a lot to change in this repo, for example, the changes here. Please guide me if I've missed any change in this PR. |
abdullahQureshee
force-pushed
the
maq/191
branch
from
0a51874 to
0556727
Compare
irtazaakram
left a comment
irtazaakram
left a comment
There was a problem hiding this comment.
This should be a support PR rather than an upgrade PR.
.github/workflows/ci.yml
Outdated
| - python_version: '3.12' | ||
| ubuntu_version: '20.04' | ||
| os: "ubuntu-20.04" | ||
| - python_version: '3.11' | ||
| - python_version: '3.12' | ||
| ubuntu_version: '22.04' | ||
| os: "ubuntu-22.04" | ||
| - python_version: '3.11' | ||
| - python_version: '3.12' | ||
| ubuntu_version: '24.04' |
There was a problem hiding this comment.
We need to support both python 3.11 & 3.12 here
setup.py
Outdated
| @@ -53,5 +53,6 @@ def get_version(*file_paths): | |||
| 'Programming Language :: Python :: 3', | |||
| 'Programming Language :: Python :: 3.8', | |||
There was a problem hiding this comment.
let's drop all references/usage of python 3.8 here
abdullahQureshee
force-pushed
the
maq/191
branch
from
0556727 to
77a6f14
Compare
abdullahQureshee
changed the title
|
@irtazaakram Can you please guide me on what is causing the pipelines to fail? This is the error: Can it be resolved from development side? |
|
The pipeline is failing due to a missing file: |
abdullahQureshee
force-pushed
the
maq/191
branch
2 times, most recently
from
aab072e to
9fbeeaa
Compare
MoisesGSalas
left a comment
MoisesGSalas
left a comment
There was a problem hiding this comment.
hi @abdullahQureshee, I recently merged a change that modifies a bit the CI workflow so please rebase when you have a chance, I left a few comments. Thanks.
| """init""" | ||
|
|
||
| __version__ = '3.5.2' | ||
| __version__ = '4.0.0' |
There was a problem hiding this comment.
We dropped support to Python 3.8 back in 06b8cd4 for version 3.5.0, so this isn't really a breaking change so simply increasing the major should be enough.
tox.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tox] | |||
| envlist = py38 | |||
There was a problem hiding this comment.
I've changed this in the master branch to only define environments for the django versions and use the python_version matrix in the CI job to test for each Python version. After rebasing use the one in master.
|
Closing in favor of #274 |
4 participants
Resolves #191